[pve-devel] [PATCH v2 qemu-server] fix #4957: add vendor and product information passthrough for SCSI-Disks

[Thomas Lamprecht]

Am 08/11/2023 um 15:28 schrieb Hannes Dürr:
> On 11/8/23 11:04, Fiona Ebner wrote:
>> Am 08.11.23 um 09:51 schrieb Hannes Duerr:
>>> +			if ($opt =~ m/scsi/) {
>>> +			    PVE::QemuServer::check_scsi_feature_compatibility($opt, $created_opts, $conf, $storecfg, $param);
>>
>> Style nit: line too long (100 characters is our limit)
>>
>> Note that $created_opts was already merged into $conf two lines above.
>> I'd rather not introduce new usage of that variable.
>>
>> Can we do the check before creating the drive instead? We know if it's a
>> CD or pass-through and the path or if it's iscsi ahead of time and that
>> should be enough for the check, or what am I missing?
> I don't think its possible to check in advance as the config can still 
> contain a not properly formed path like:
> 'local-lvm:5', which will be formed to the real path when creating the 
> disk or am I mistaken ?

But all information is still there? I.e., the disk's bus, like scsi, and if any
vendor or product properties are set. So you can still parse that value and check
validity.

>>> +			}
>>> +		    }
>>>   		    if (!$conf->{boot}) {
>>>   			my $devs = PVE::QemuServer::get_default_bootdevices($conf);
>>>   			$conf->{boot} = PVE::QemuServer::print_bootorder($devs);

>> (...)
> what does that mean ?

That fiona snipped (trimmed) some context due to it not being relevant for
the reveiw, like in quotes, albeit they more often use brackets there, like
"[...] lorem ipsum"