[pve-devel] [PATCH pve-firewall 1/2] Manually construct guest config path

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 8 15:31:35 CET 2023

Am 08/11/2023 um 12:35 schrieb Stefan Lendl:
> Remove require QemuConfig from Firewall.pm
> We only use it to construct the guest config paths.
> Fixes circular include when accessing Firewall::Aliases from
> pve-network.

This won't work as now cfs_read_file only works by luck, if at all, as the
cfs_read_file needs the cfs_register_file that happens in PVE::QemuServer
so that the parser is actually available...

I'd much rather see Firewall be split-up than doing broken hacks and
switching from one of our saner interfaces to manual assembly.

More information about the pve-devel mailing list