[pve-devel] [PATCH installer v4 0/6] fix #4829: wire up `arc_max` ZFS option to GUI/TUI for PVE

Christoph Heiss c.heiss at proxmox.com
Tue Nov 7 13:20:48 CET 2023

The installer `arc_max` option ZFS was introduced in [0], this exposes
this option in the GUI/TUI installer for PVE installations.

This can be adjusted when creating a ZFS RAID under "Advanced Options".
The default value is choosen as 10% of system memory, clamped to between
64 MiB as lower limit and 16 GiB as upper limit. For PBS and PMG, the
option is (currently) hidden.

Tested by installing PVE, PBS and PMG, using both the GUI and TUI
installer. For PVE, checked that the `zfs` module option gets correctly
written & applied, the latter by looking at the output of `arc_summary`.
For PBS and PMG, verified that no modprobe options file is created and
the ARC size is set to default.

[0] https://lists.proxmox.com/pipermail/pve-devel/2023-October/059731.html

v1: https://lists.proxmox.com/pipermail/pve-devel/2023-August/058830.html
v2: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059606.html
v3: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059731.html

Notable changes v1 -> v2:
  * rebased on latest master
  * fix arc_max value set in TUI not being applied correctly

Notable changes v2 -> v3:
  * rebased on latest master
  * new patch explaining query_total_memory, which is used extensively
    in this patchset
  * new patch unifying product handling a bit
  * documented all calculations better w.r.t. to their units
  * moved modprobe setup into separate sub

Notable changes v3 -> v4:
  * rebased on latest master
  * dropped already applied patches from series
  * added new patch to drop debug print
  * added new patch fixing zfs_arc_max modprobe setting

Christoph Heiss (6):
  run env: remove debug print
  install: use correct variable names in zfs_setup_module_conf()
  proxinstall: expose `arc_max` ZFS option for PVE installations
  test: add tests for zfs_arc_max calculations
  common: add ZFS `arc_max` installer setup option
  tui: bootdisk: expose `arc_max` ZFS option for PVE installations

 Makefile                                    |  3 +
 Proxmox/Install.pm                          |  4 +-
 Proxmox/Install/RunEnv.pm                   |  1 -
 debian/control                              |  1 +
 proxinstall                                 | 15 ++++
 proxmox-installer-common/src/options.rs     | 62 ++++++++++++++--
 proxmox-installer-common/src/setup.rs       |  2 +
 proxmox-tui-installer/src/main.rs           |  2 +-
 proxmox-tui-installer/src/views/bootdisk.rs | 82 ++++++++++++++-------
 proxmox-tui-installer/src/views/mod.rs      |  1 -
 test/Makefile                               | 10 +++
 test/zfs-arc-max.pl                         | 81 ++++++++++++++++++++
 12 files changed, 228 insertions(+), 36 deletions(-)
 create mode 100644 test/Makefile
 create mode 100755 test/zfs-arc-max.pl


More information about the pve-devel mailing list