[pve-devel] [PATCH manager 1/2] ui: BulkActions: rework filters and include tags

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 6 17:01:28 CET 2023

for the commit subject please: s/BulkActions/bulk actions/

Am 30/10/2023 um 13:58 schrieb Dominik Csapak:
> This moves the filters out of the grid header for the BulkActions and
> puts them into their own fieldset above the grid. With that, we can
> easily include a tags filter (one include and one exclude list).
> The filter fieldset is collapsible and shows the active filters in
> parenthesis. aside from that the filter should be the same as before.

basic tests seem to work, and I did not really check the code closely,
so only a higher level review, and some stuff is even pre-existing (but
sticks a bit more out now):

- the CT/VM ID filter is a bit odd, especially if tuned to match all,
  not only parts of the VMID (which would not be *that* much better
  either IMO), when I want to migrate/start/stop a single VM I can just
  do so, no need for opening the bulk actions.

- The migration one should move target and jobs into two columns, as of
  now there's just to much vertical space used.

- Maybe we can also merge the "allow local disk" check box and the
  warning for "ct will use restart mode" into columns (the former could
  loose the box label, that note is not really that useful anyway)

- In the spirit of the last two points, the shutdown action might also
  benefit from having force-stop and timeout on the same row in two

- We have a mix of title case and sentence case for the fields, they
  should all use title case (I find https://titlecaseconverter.com/
  nice). E.g., should be "HA Status" in the filters, and Parallel Jobs
  for migration, and so on.

- tag space is very limited, maybe default to using circles or even
  dense (I'm still wishing a bit for seeing the tag value on hover, like
  a tool tip), or re-use the tree-style shape.
  One alternative might be to add vertical scrolling here, but that is
  probably rather odd (and not sure if that would even work easily

- disallowing multi-select for Type (maybe better labeled "Guest Type"?)
  might improve UX, as if there are only two choices anyway a "All",
  "VM" "CT" selection might be simpler – but no hard feelings here.

More information about the pve-devel mailing list