[pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

Dominik Csapak d.csapak at proxmox.com
Mon Nov 6 10:34:27 CET 2023


On 11/6/23 10:22, Fiona Ebner wrote:
> Am 03.11.23 um 12:53 schrieb Dominik Csapak:
>> +my $defaultData = {
>> +    propertyList => {
>> +	type => { description => 'Profile type.' },
>> +	id => {
>> +	    type => 'string',
>> +	    description => "The ID of the profile.",
>> +	    format => 'pve-configid',
>> +	},
> 
> The ID is usually not a property AFAIK. Doesn't this lead to duplication
> when writing the section config, i.e.
> 
> type: <ID>
> 	id <ID>
> 
> ? Do we gain anything by having it be a property?

mhm? the id has to be part of the properties, otherwise
the generated api with 'createSchema' etc. would not include it.

(it isn't always named id, e.g. in the storage plugins
it's 'storage')





More information about the pve-devel mailing list