[pve-devel] aüüöoed: [PATCH docs] correct outdated info about gui header

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 2 20:47:04 CET 2023

On 02/11/2023 16:08, Dominik Csapak wrote:
> the header part of the gui did change, by moving the user name into a
> button, which now contains more user specific actions. Update it to be
> correct again.

applied, with some language follow-ups, thanks — keeping such things
up-to-date is important work!

> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  pve-gui.adoc | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> diff --git a/pve-gui.adoc b/pve-gui.adoc
> index 9f63a7e..046fb9f 100644
> --- a/pve-gui.adoc
> +++ b/pve-gui.adoc
> @@ -101,21 +101,23 @@ search bar nearside you can search for specific objects (VMs,
>  containers, nodes, ...). This is sometimes faster than selecting an
>  object in the resource tree.
> -To the right of the search bar we see the identity (login name). The
> -gear symbol is a button opening the 'My Settings' dialog. There you
> -can customize some client side user interface setting (reset the saved
> -login name, reset saved layout).
> -
> -The rightmost part of the header contains four buttons:
> +The right part of the header contains four buttons:
>  [horizontal]
> -Help :: Opens a new browser window showing the reference documentation.
> +Documentation :: Opens a new browser window showing the reference documentation.
>  Create VM :: Opens the virtual machine creation wizard.
>  Create CT :: Open the container creation wizard.
> -Logout :: Logout, and show the login dialog again.
> +Identity Menu :: Displays the identity and contains user specific options.

IMO that name is rather odd.. changed to "User Menu"

I connected the following paragraph with the above definition-list entry
by placing a "+" on the empty line, that way they are separate paragraphs
but still indented on the same level, which IMO makes sense for the menu
child entries.

> +
> +The identity menu contains various user specific options, such as the 'My

"various user specific options" is a repetition from the list above, sticks
especially out because it's already a bit superfluous there too, i.e., what
else would the "user menu" contain? ^^

> +Settings' dialog. There you can customize some client side user interface
> +setting (reset the saved login name, reset saved layout).

I reworded to avoid the parenthesis, but they were mostly pre-exsiting,
so just mentioning for the record.

> +
> +It also contains a shortcut to the 'TFA', 'Language' and 'Color Theme'
> +settings, as well as the Logout option.
>  [[gui_my_settings]]

More information about the pve-devel mailing list