[pve-devel] applied: [PATCH http-server] fix regression in api/html (bootstrap) viewer

Thomas Lamprecht t.lamprecht at proxmox.com
Tue May 30 14:43:59 CEST 2023

Am 30/05/2023 um 13:56 schrieb Dominik Csapak:
> recent versions of URI::Escape seem to handle the 'unsafe characters'
> parameter differently than before, enforcing what is documented:
>  The set is specified as a string that can be used in a regular
>  expression character class (between [ ]).
> so the leading/trailing [] were never supposed to be there.

Since liburi-perl 5.15 we could also use a qr// regex object [0], maybe that
would be a bit more explicit here; Debian Bookworm has already 5.17 available.

[0]: https://github.com/libwww-perl/URI/commit/a3f96169b002e1fa747713654edfa9f528d17cbb

> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  src/PVE/APIServer/Formatter/Bootstrap.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Anyhow, we don't have to touch this often and its for a dev/debug features, so
for now:

applied, with commit message amended with referencing the commit that broke
our usage and the possibility of regex objects, thanks!

More information about the pve-devel mailing list