[pve-devel] [PATCH v2 pve-guest-common 26/42] vzdump: add config options for new notification backend

Lukas Wagner l.wagner at proxmox.com
Wed May 24 15:56:33 CEST 2023


- Add new option 'notification-mode'
  Can either be 'mail' or 'channel', selects wheter notifications should
  be sent via email or via a notification channel
- Add new option 'notification-channel'
  Allows to select a channel via which notifications shall be sent (if
  'notification-mode' is set to 'channel')
- Add new option 'notification-policy'
  Replacement for the now deprecated 'mailnotification' option. Mostly
  just a rename for consistency, but also adds the 'never' option.
- Mark 'mailnotification' as deprecated in favor of 'notification-policy'

Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---
 src/PVE/VZDump/Common.pm | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 4b0e8e0..d3cf8a7 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -164,16 +164,40 @@ my $confdesc = {
 	type => 'string',
 	format => 'email-or-username-list',
 	description => "Comma-separated list of email addresses or users that should" .
-	    " receive email notifications.",
+	    " receive email notifications. Only has an effect if 'notification-mode' is".
+	    " set to 'mail'.",
 	optional => 1,
     },
     mailnotification => {
 	type => 'string',
-	description => "Specify when to send an email",
+	description => "Deprecated: use 'notification-policy' instead.",
 	optional => 1,
 	enum => [ 'always', 'failure' ],
 	default => 'always',
     },
+    'notification-policy' => {
+	type => 'string',
+	description => "Specify when to send a notification",
+	optional => 1,
+	enum => [ 'always', 'failure', 'never'],
+	default => 'always',
+    },
+    'notification-mode' => {
+	type => 'string',
+	description => "Determine whether to notify via email of via a notification channel.",
+	optional => 1,
+	enum => [ 'mail', 'channel' ],
+	default => 'mail',
+    },
+    'notification-channel' => {
+	type => 'string',
+	format => 'pve-configid',
+	description => "Determine the channel via which notifications should be sent." .
+	    " Only has an effect if 'notification-mode' is set to 'channel'." .
+	    " If 'notification-mode' is set to 'channel' and 'notification-channel' is " .
+	    " not set, then no notification will be sent.",
+	optional => 1,
+    },
     tmpdir => {
 	type => 'string',
 	description => "Store temporary files to specified directory.",
-- 
2.30.2






More information about the pve-devel mailing list