[pve-devel] [PATCH-SERIES v2 qemu-server/qemu] Some breaking QEMU changes

Fiona Ebner f.ebner at proxmox.com
Wed May 24 15:56:48 CEST 2023


First one is dropping the custom get_link_status QMP command which I
could not find any users for.

Second one is dropping left-over, custom, deprecated QMP commands for
drive snapshotting.

Third one is dropping the dummy id CLI parameter, where the only
remaining user I found is qmeventd, which is adapted to parse the VM
ID from the cgroup proc file instead.

With the third change, new pve-qemu-kvm will break old qemu-server,
requiring a versioned breaks.


Changes in v2:
    * also drop deprecated drive snapshot QMP commands


qemu-server:

Fiona Ebner (3):
  remove left-over mentions of to-be-dropped, outdated QMP commands
  qmeventd: extract vmid from cgroup file instead of cmdline
  cfg2cmd: drop custom id parameter

 PVE/QMPClient.pm                              |  4 +-
 PVE/QemuServer.pm                             |  2 -
 qmeventd/qmeventd.c                           | 50 +++++++++++--------
 test/cfg2cmd/bootorder-empty.conf.cmd         |  1 -
 test/cfg2cmd/bootorder-legacy.conf.cmd        |  1 -
 test/cfg2cmd/bootorder.conf.cmd               |  1 -
 ...putype-icelake-client-deprecation.conf.cmd |  1 -
 .../custom-cpu-model-defaults.conf.cmd        |  1 -
 .../custom-cpu-model-host-phys-bits.conf.cmd  |  1 -
 test/cfg2cmd/custom-cpu-model.conf.cmd        |  1 -
 test/cfg2cmd/efi-raw-old.conf.cmd             |  1 -
 test/cfg2cmd/efi-raw-template.conf.cmd        |  1 -
 test/cfg2cmd/efi-raw.conf.cmd                 |  1 -
 test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd |  1 -
 test/cfg2cmd/efi-secboot-and-tpm.conf.cmd     |  1 -
 test/cfg2cmd/efidisk-on-rbd.conf.cmd          |  1 -
 test/cfg2cmd/i440fx-win10-hostpci.conf.cmd    |  1 -
 .../cfg2cmd/memory-hotplug-hugepages.conf.cmd |  1 -
 test/cfg2cmd/memory-hotplug.conf.cmd          |  1 -
 test/cfg2cmd/memory-hugepages-1g.conf.cmd     |  1 -
 test/cfg2cmd/memory-hugepages-2m.conf.cmd     |  1 -
 test/cfg2cmd/minimal-defaults.conf.cmd        |  1 -
 test/cfg2cmd/netdev-7.0-multiqueues.conf.cmd  |  1 -
 test/cfg2cmd/netdev-7.1-multiqueues.conf.cmd  |  1 -
 test/cfg2cmd/netdev-7.1.conf.cmd              |  1 -
 test/cfg2cmd/netdev.conf.cmd                  |  1 -
 test/cfg2cmd/pinned-version-pxe-pve.conf.cmd  |  1 -
 test/cfg2cmd/pinned-version-pxe.conf.cmd      |  1 -
 test/cfg2cmd/pinned-version.conf.cmd          |  1 -
 .../q35-linux-hostpci-multifunction.conf.cmd  |  1 -
 ...q35-linux-hostpci-x-pci-overrides.conf.cmd |  1 -
 test/cfg2cmd/q35-linux-hostpci.conf.cmd       |  1 -
 test/cfg2cmd/q35-simple-6.0.conf.cmd          |  1 -
 test/cfg2cmd/q35-simple-7.0.conf.cmd          |  1 -
 test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd   |  1 -
 test/cfg2cmd/q35-simple.conf.cmd              |  1 -
 test/cfg2cmd/q35-usb2.conf.cmd                |  1 -
 test/cfg2cmd/q35-usb3.conf.cmd                |  1 -
 test/cfg2cmd/q35-win10-hostpci.conf.cmd       |  1 -
 test/cfg2cmd/qemu-xhci-7.1.conf.cmd           |  1 -
 test/cfg2cmd/qemu-xhci-q35-7.1.conf.cmd       |  1 -
 test/cfg2cmd/seabios_serial.conf.cmd          |  1 -
 ...imple-balloon-free-page-reporting.conf.cmd |  1 -
 test/cfg2cmd/simple-btrfs.conf.cmd            |  1 -
 test/cfg2cmd/simple-virtio-blk.conf.cmd       |  1 -
 test/cfg2cmd/simple1-template.conf.cmd        |  1 -
 test/cfg2cmd/simple1.conf.cmd                 |  1 -
 test/cfg2cmd/spice-enhancments.conf.cmd       |  1 -
 test/cfg2cmd/spice-linux-4.1.conf.cmd         |  1 -
 test/cfg2cmd/spice-usb3.conf.cmd              |  1 -
 test/cfg2cmd/spice-win.conf.cmd               |  1 -
 test/snapshot-test.pm                         |  3 --
 52 files changed, 31 insertions(+), 76 deletions(-)


qemu:

Fiona Ebner (3):
  drop patch for custom get_link_status QMP command
  drop deprecated custom drive snapshot QMP commands
  drop patch for custom dummy id CLI argument

 ...VE-Up-glusterfs-allow-partial-reads.patch} |   0
 .../0007-PVE-Up-qmp-add-get_link_status.patch |  98 -----------------
 ...eturn-success-on-info-without-snaps.patch} |   0
 ...d-add-osize-and-read-from-to-stdin-.patch} |   0
 ...-Up-qemu-img-dd-add-isize-parameter.patch} |   0
 ...VE-Up-qemu-img-dd-add-n-skip_create.patch} |   0
 ...add-l-option-for-loading-a-snapshot.patch} |   0
 ...irtio-balloon-improve-query-balloon.patch} |   4 +-
 ...0014-PVE-qapi-modify-query-machines.patch} |   0
 ...=> 0015-PVE-qapi-modify-spice-query.patch} |   0
 ...nel-implementation-for-savevm-async.patch} |   0
 ...sync-for-background-state-snapshots.patch} | 101 +++---------------
 ...dd-optional-buffer-size-to-QEMUFile.patch} |   4 +-
 ...dd-the-zeroinit-block-driver-filter.patch} |   0
 ...-target-i386-disable-LINT0-after-re.patch} |   0
 ...-Add-dummy-id-command-line-parameter.patch |  55 ----------
 ...e-posix-make-locking-optiono-on-cre.patch} |   0
 ...-PVE-monitor-disable-oob-capability.patch} |   0
 ...ed-balloon-qemu-4-0-config-size-fal.patch} |   0
 ...-Allow-version-code-in-machine-type.patch} |   4 +-
 ...-bcs-bitmap-initialization-to-job-c.patch} |   0
 ...E-Backup-add-vma-backup-format-code.patch} |   0
 ...Backup-add-backup-dump-block-driver.patch} |   0
 ...-sequential-job-transaction-support.patch} |   0
 ...kup-Proxmox-backup-patches-for-QEMU.patch} |   6 +-
 ...store-new-command-to-restore-from-p.patch} |   0
 ...-driver-to-map-backup-archives-into.patch} |   4 +-
 ...t-stderr-to-journal-when-daemonized.patch} |   0
 ...grate-dirty-bitmap-state-via-savevm.patch} |   0
 ...irty-bitmap-migrate-other-bitmaps-e.patch} |   0
 ...ll-back-to-open-iscsi-initiatorname.patch} |   0
 ...VE-block-stream-increase-chunk-size.patch} |   0
 ...ccept-NULL-qiov-in-bdrv_pad_request.patch} |   0
 ...> 0038-block-add-alloc-track-driver.patch} |   0
 ...rbd-workaround-for-ceph-issue-53784.patch} |   0
 ...fix-handling-of-holes-in-.bdrv_co_b.patch} |   0
 ...-rbd-implement-bdrv_co_block_status.patch} |   0
 ...lloc-track-fix-deadlock-during-drop.patch} |   0
 ...pshots-hold-the-BQL-during-setup-ca.patch} |   0
 ...m-async-don-t-hold-BQL-during-setup.patch} |   2 +-
 debian/patches/series                         |  78 +++++++-------
 41 files changed, 66 insertions(+), 290 deletions(-)
 rename debian/patches/pve/{0008-PVE-Up-glusterfs-allow-partial-reads.patch => 0007-PVE-Up-glusterfs-allow-partial-reads.patch} (100%)
 delete mode 100644 debian/patches/pve/0007-PVE-Up-qmp-add-get_link_status.patch
 rename debian/patches/pve/{0009-PVE-Up-qemu-img-return-success-on-info-without-snaps.patch => 0008-PVE-Up-qemu-img-return-success-on-info-without-snaps.patch} (100%)
 rename debian/patches/pve/{0010-PVE-Up-qemu-img-dd-add-osize-and-read-from-to-stdin-.patch => 0009-PVE-Up-qemu-img-dd-add-osize-and-read-from-to-stdin-.patch} (100%)
 rename debian/patches/pve/{0011-PVE-Up-qemu-img-dd-add-isize-parameter.patch => 0010-PVE-Up-qemu-img-dd-add-isize-parameter.patch} (100%)
 rename debian/patches/pve/{0012-PVE-Up-qemu-img-dd-add-n-skip_create.patch => 0011-PVE-Up-qemu-img-dd-add-n-skip_create.patch} (100%)
 rename debian/patches/pve/{0013-qemu-img-dd-add-l-option-for-loading-a-snapshot.patch => 0012-qemu-img-dd-add-l-option-for-loading-a-snapshot.patch} (100%)
 rename debian/patches/pve/{0014-PVE-virtio-balloon-improve-query-balloon.patch => 0013-PVE-virtio-balloon-improve-query-balloon.patch} (99%)
 rename debian/patches/pve/{0015-PVE-qapi-modify-query-machines.patch => 0014-PVE-qapi-modify-query-machines.patch} (100%)
 rename debian/patches/pve/{0016-PVE-qapi-modify-spice-query.patch => 0015-PVE-qapi-modify-spice-query.patch} (100%)
 rename debian/patches/pve/{0017-PVE-add-IOChannel-implementation-for-savevm-async.patch => 0016-PVE-add-IOChannel-implementation-for-savevm-async.patch} (100%)
 rename debian/patches/pve/{0018-PVE-add-savevm-async-for-background-state-snapshots.patch => 0017-PVE-add-savevm-async-for-background-state-snapshots.patch} (91%)
 rename debian/patches/pve/{0019-PVE-add-optional-buffer-size-to-QEMUFile.patch => 0018-PVE-add-optional-buffer-size-to-QEMUFile.patch} (98%)
 rename debian/patches/pve/{0020-PVE-block-add-the-zeroinit-block-driver-filter.patch => 0019-PVE-block-add-the-zeroinit-block-driver-filter.patch} (100%)
 rename debian/patches/pve/{0022-PVE-Config-Revert-target-i386-disable-LINT0-after-re.patch => 0020-PVE-Config-Revert-target-i386-disable-LINT0-after-re.patch} (100%)
 delete mode 100644 debian/patches/pve/0021-PVE-Add-dummy-id-command-line-parameter.patch
 rename debian/patches/pve/{0023-PVE-Up-Config-file-posix-make-locking-optiono-on-cre.patch => 0021-PVE-Up-Config-file-posix-make-locking-optiono-on-cre.patch} (100%)
 rename debian/patches/pve/{0024-PVE-monitor-disable-oob-capability.patch => 0022-PVE-monitor-disable-oob-capability.patch} (100%)
 rename debian/patches/pve/{0025-PVE-Compat-4.0-used-balloon-qemu-4-0-config-size-fal.patch => 0023-PVE-Compat-4.0-used-balloon-qemu-4-0-config-size-fal.patch} (100%)
 rename debian/patches/pve/{0026-PVE-Allow-version-code-in-machine-type.patch => 0024-PVE-Allow-version-code-in-machine-type.patch} (98%)
 rename debian/patches/pve/{0027-block-backup-move-bcs-bitmap-initialization-to-job-c.patch => 0025-block-backup-move-bcs-bitmap-initialization-to-job-c.patch} (100%)
 rename debian/patches/pve/{0028-PVE-Backup-add-vma-backup-format-code.patch => 0026-PVE-Backup-add-vma-backup-format-code.patch} (100%)
 rename debian/patches/pve/{0029-PVE-Backup-add-backup-dump-block-driver.patch => 0027-PVE-Backup-add-backup-dump-block-driver.patch} (100%)
 rename debian/patches/pve/{0030-PVE-Add-sequential-job-transaction-support.patch => 0028-PVE-Add-sequential-job-transaction-support.patch} (100%)
 rename debian/patches/pve/{0031-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch => 0029-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch} (99%)
 rename debian/patches/pve/{0032-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch => 0030-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch} (100%)
 rename debian/patches/pve/{0033-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch => 0031-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch} (99%)
 rename debian/patches/pve/{0034-PVE-redirect-stderr-to-journal-when-daemonized.patch => 0032-PVE-redirect-stderr-to-journal-when-daemonized.patch} (100%)
 rename debian/patches/pve/{0035-PVE-Migrate-dirty-bitmap-state-via-savevm.patch => 0033-PVE-Migrate-dirty-bitmap-state-via-savevm.patch} (100%)
 rename debian/patches/pve/{0036-migration-block-dirty-bitmap-migrate-other-bitmaps-e.patch => 0034-migration-block-dirty-bitmap-migrate-other-bitmaps-e.patch} (100%)
 rename debian/patches/pve/{0037-PVE-fall-back-to-open-iscsi-initiatorname.patch => 0035-PVE-fall-back-to-open-iscsi-initiatorname.patch} (100%)
 rename debian/patches/pve/{0038-PVE-block-stream-increase-chunk-size.patch => 0036-PVE-block-stream-increase-chunk-size.patch} (100%)
 rename debian/patches/pve/{0039-block-io-accept-NULL-qiov-in-bdrv_pad_request.patch => 0037-block-io-accept-NULL-qiov-in-bdrv_pad_request.patch} (100%)
 rename debian/patches/pve/{0040-block-add-alloc-track-driver.patch => 0038-block-add-alloc-track-driver.patch} (100%)
 rename debian/patches/pve/{0041-Revert-block-rbd-workaround-for-ceph-issue-53784.patch => 0039-Revert-block-rbd-workaround-for-ceph-issue-53784.patch} (100%)
 rename debian/patches/pve/{0042-Revert-block-rbd-fix-handling-of-holes-in-.bdrv_co_b.patch => 0040-Revert-block-rbd-fix-handling-of-holes-in-.bdrv_co_b.patch} (100%)
 rename debian/patches/pve/{0043-Revert-block-rbd-implement-bdrv_co_block_status.patch => 0041-Revert-block-rbd-implement-bdrv_co_block_status.patch} (100%)
 rename debian/patches/pve/{0044-alloc-track-fix-deadlock-during-drop.patch => 0042-alloc-track-fix-deadlock-during-drop.patch} (100%)
 rename debian/patches/pve/{0045-migration-for-snapshots-hold-the-BQL-during-setup-ca.patch => 0043-migration-for-snapshots-hold-the-BQL-during-setup-ca.patch} (100%)
 rename debian/patches/pve/{0046-savevm-async-don-t-hold-BQL-during-setup.patch => 0044-savevm-async-don-t-hold-BQL-during-setup.patch} (97%)

-- 
2.39.2






More information about the pve-devel mailing list