[pve-devel] [PATCH v2 qemu-server 1/3] remove left-over mentions of to-be-dropped, outdated QMP commands

Fiona Ebner f.ebner at proxmox.com
Wed May 24 15:56:49 CEST 2023


The commands snapshot-drive and delete-drive-snapshot have been unused
by qemu-server since commit eba2b721 ("use qemu's blockdev-snapshot
functions") and are now going to be dropped in our QEMU builds too, so
get rid of these left-overs.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---

New in v2.

 PVE/QMPClient.pm      | 4 +---
 test/snapshot-test.pm | 3 ---
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm
index 3bc5eaa1..ef5c19b3 100644
--- a/PVE/QMPClient.pm
+++ b/PVE/QMPClient.pm
@@ -126,12 +126,10 @@ sub cmd {
 	    $cmd->{execute} eq 'block-job-complete' ||
 	    $cmd->{execute} eq 'backup-cancel' ||
 	    $cmd->{execute} eq 'query-savevm' ||
-	    $cmd->{execute} eq 'delete-drive-snapshot' ||
 	    $cmd->{execute} eq 'guest-fstrim' ||
 	    $cmd->{execute} eq 'guest-shutdown' ||
 	    $cmd->{execute} eq 'blockdev-snapshot-internal-sync' ||
-	    $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync' ||
-	    $cmd->{execute} eq 'snapshot-drive'
+	    $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync'
 	 ) {
 	    $timeout = 10*60; # 10 mins ?
 	} else {
diff --git a/test/snapshot-test.pm b/test/snapshot-test.pm
index d26b4223..dd69fa31 100644
--- a/test/snapshot-test.pm
+++ b/test/snapshot-test.pm
@@ -328,9 +328,6 @@ sub qmp_cmd {
     my ($vmid, $cmd) = @_;
 
     my $exec = $cmd->{execute};
-    if ($exec eq "delete-drive-snapshot") {
-	return;
-    }
     if ($exec eq "guest-ping") {
 	die "guest-ping disabled\n"
 	    if !$vm_mon->{guest_ping};
-- 
2.39.2






More information about the pve-devel mailing list