[pve-devel] [RFC PATCH common] section config: implement array support

Dominik Csapak d.csapak at proxmox.com
Thu May 11 13:30:22 CEST 2023


thanks for your feedback @fabian, @wolfgang!

so the consensus seems to be to simply expose the array in the api schema and
always have the client send the whole array over, like in pbs updater
(not a problem for my series, since in the gui we have the whole info anyway,
also if one want a custom api can always be created instead of using the
create/updateSchema methods)

I'd adapt my patch, and enable arrays in the pve-http-server instead of our
'-alist' format (which we only ever use in two places AFAICS) and replace those
by an array type

(there are a few things that must change in JSONSchema/CLIHandler to fully support arrays,
but that's only minor things, such as doing the untainting correctly)

i'd then remove support for the '-alist' format completely since it'll not
work anymore (at least in the api). FWICT this isn't even a real api
change, since the client would send the data in exactly the same way as
before, but we'll send the parameters along as arrays instead of \0-separated strings

Any other opinions @Thomas?

does that work for everybody?





More information about the pve-devel mailing list