[pve-devel] [PATCH manager 0/2] ui: fw: allow selecting network interface for rules using combogrid
Christoph Heiss
c.heiss at proxmox.com
Thu May 11 11:46:18 CEST 2023
For nodes, VMs and CTs we can show the user a list of available network
interfaces (as that information is available) when creating a new
firewall rule, much like it is already done in similar places.
Adds a lot of convenience when creating new firewall rules if they are
interface-specific, as you get a nice summary of the available ones and
can simply select it instead of typing it out each time.
The first patch refactors the `BridgeSelector` component a bit into a
new `NetworkInterfaceSelector`, is essence allowing it be used for any
type of network interfaces. No functional changes there.
The second patch contains the actual implementation, using the
`NetworkInterfaceSelector` from above for nodes and introducing a new
component (which is mostly based of the former) for VMs/CTs.
For datacenter rules, the simple textbox is kept.
pve-manager:
Christoph Heiss (2):
ui: fw: generalize `BridgeSelector` into network interface selector
ui: fw: allow selecting network interface for rules using combogrid
www/manager6/Makefile | 3 +-
www/manager6/form/BridgeSelector.js | 71 -----------------
www/manager6/form/NetworkInterfaceSelector.js | 79 +++++++++++++++++++
.../form/VMNetworkInterfaceSelector.js | 79 +++++++++++++++++++
www/manager6/grid/FirewallRules.js | 37 ++++++++-
www/manager6/lxc/Config.js | 1 +
www/manager6/lxc/Network.js | 3 +-
www/manager6/qemu/Config.js | 1 +
www/manager6/qemu/NetworkEdit.js | 3 +-
9 files changed, 199 insertions(+), 78 deletions(-)
--
2.39.2
More information about the pve-devel
mailing list