[pve-devel] How to fix a patch already sent ???

Fabian Grünbichler f.gruenbichler at proxmox.com
Mon May 8 10:12:47 CEST 2023


> Jorge Ventura via pve-devel <pve-devel at lists.proxmox.com> hat am 06.05.2023 22:44 CEST geschrieben:
> I sent a patch recently that is working properly but later I detected
> a warning from the Perl interpreter.
> 
> How should I proceed?
> 1) Send a single [PATCH 1/1] completely fixed ?

this option, but mark the PATCH as v2 (and include a short changelog in the commit summary section, which is the part below '---' where the diff stat generated by git is).

[PATCH v2 pve-manager 1/1] commit subject

see https://pve.proxmox.com/wiki/Developer_Documentation#Versioned_Patches for how to do that using git commands.

> 2) Send dual [PATCH 1/2 and 2/2] with the previous patch plus the fix
> to the previous patch?
> 
> What is the correct procedure for a situation like this?
> 
> Sincerely,
> Ventura





More information about the pve-devel mailing list