[pve-devel] [PATCH v2 qemu-server 2/2] remote-migration: add target-cpu param

[Fabian Grünbichler]

On April 29, 2023 9:57 am, Thomas Lamprecht wrote:
> Am 28/04/2023 um 11:12 schrieb Fabian Grünbichler:
>>> It's was more about "offline" term, because we don't offline the source
>>> vm until the disk migration is finished. (to reduce downtime)
>>> More like "online-restart" instead "offline".
>>>
>>> Offline for me , is really, we shut the vm, then do the disk migration.
>> hmm, I guess how you see it. for me, online means without interruption,
>> anything else is offline 😄 but yeah, naming is hard, as always 😉
> 
> FWIW, in Proxmox Container land that's currently basically the "most online"
> it gets, and there it's named "restore migration" – at least if we go for the
> "clean reboot for actual moving the guest over" approach.

"restart", you meant? yes, but it's explicitly not "online", it's a
second parameter besides that called "restart" that cannot be combined
with "online" (nothing can, since setting "online" leads to a hard error
if the VM is running).

it also does the following:

- stop CT on source node (if running)
- storage migration (via pve-storage)
- start CT again on target node (if previously running)

similar to this series, but not quite:

- start storage migration (via pve-storage for unused/.., live via qemu
  for currently used volumes)
- wait for storage migration convergence
- stop VM on source node / complete block job (details still to be hashed out)
- start VM on target node

so naming what this series does "restart" might be confusing, since the
most fundamental part is different (the downtime is only for the restart
part, as opposed to for restart+storage migration).