[pve-devel] [PATCH pve-widget-toolkit] Changed 'kr' to 'ko' in language list
t.lamprecht at proxmox.com
Sun Mar 26 16:51:59 CEST 2023
Am 24/03/2023 um 15:41 schrieb Noel Ullreich:
> the ISO 639-1 two letter abbreviation of Korean is 'ko', not 'kr'
great find, but without renaming the PO file this breaks the whole translation
completely, which isn't ideal for users - as for them the underlying used two
letter code was just an invisible implementation detail.
So I'd do the rename there, but that then needs to handle the update
In widget-toolkit we do not depend on any i18n package as widget-toolkit is
also used in more than one project; adding an OR'd `pve-i18n | pmg-i18n |
pbs-i18n` could work but is a bit of a PITA as some tools will use the first
one here (e.g. debootstrap) if one isn't careful. So, we could instead add a
virtual proxmox-widget-toolkit-i18n package that all pmg/pve/pbs- i18n ones
provide as $binary:version and make proxmox-widget-toolkit depend on that;
would be IMO slightly cleaner.
Independent from what will be used to track the dependency from wtk to i18n, we
would need to break older widget-toolkit in newer i18n and depend on newer i18n
(via or'd or virtual) in newer widget toolkit; that is if we straight do the
But, that'd not solve the setups out there with users having kr in the
PVELangCookie (or PBS/PMG) already set.
For that we'd need to either ship also a symlink for the previously used kr.po,
plus some code stanza that checks the cookie and sets it to `ko` if it is `kr`,
which can then be removed someday, maybe trixie. Otherwise we could simply
translate this in the http servers back to ko, but not much of a point in
renaming it now then.
anyway & tldr; we learn that renaming translation files can bring a lot of
required churn to ensure backward compatibility. Would be easier to just
mention that this is using the ISO 3166 Alpha 2 for south korea and that
changing it is rather hard and a not so great ROI, so we keep it until we
actually get a translation (request) for the language that ISO 639-1 `kr`
refers to. So, correctness aside, this would be waaay faster and have less
breakage potential ¯\_(ツ)_/¯
More information about the pve-devel