[pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more"

[Stefan Sterz]

On 3/21/23 14:05, Thomas Lamprecht wrote:
> Am 21/03/2023 um 11:04 schrieb Wolfgang Bumiller:
>> This looks horrible.
>>
>> A *much* *much* better way to improve readability is to
>> simply set the opacity down to 0.5.
>>
>> This reverts commit 2c837f5766b48629a835c62d4b7af6c3ae4dc1c0.
>> ---
>> I can't stand this.
>> Seriously.
>>
>>  src/proxmox-dark/scss/extjs/_presentation.scss | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>
> 
> applied all three patches, they actually fulfil my request to be able to still
> read the stuff in the bg even a bit better and look fine enough otherwise, thanks!
> 
> FWIW, just from a aesthetic POV the best way to make modal windows stand out would
> be to blur the background, i.e.:
> 
> .x-mask {
>     background-color: rgba(0,0,0,0.5);
>     backdrop-filter: blur(2px);
> }
> 
> (backdrop-filter + opacity doesn't work, so one needs to use rgba instead)
> 
> But I prefer usability/accessibility over aesthetics here.
> 

well rgba values sadly don't work properly with sassc. so that will
become a solid black background.

also as discussed off-list, setting the background of the mask to black
looks awkward/less consistent with crisp in several situation (e.g., the
retention tab of a zfs storage or the quarantine mail preview panel).

however @Wolfgang and i agreed on the following:

.x-mask {
  background-color: $background-darker;
  opacity: 0.5;
}

.x-css-shadow {
  box-shadow: black 0 -1px 15px 5px !important;
}

that should hopefully fullfill all three requirements (see-through,
contrast to background, not looking strange in the given situations).

> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>