[pve-devel] applied: [PATCH v2 storage] config: use relative paths for content overrides

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Mar 20 15:26:02 CET 2023


Am 14/03/2023 um 14:14 schrieb Leo Nunner:
> Remove the requirement for paths to start with a /, as it might be
> confusing to users.
> 
> Signed-off-by: Leo Nunner <l.nunner at proxmox.com>
> ---
> RFC: I'm not really sure how much input validation we want to do here.
> e.g., should we keep the user from appending or prepending slashes (e.g.
> setting the override as /dir/)? Or should we just accept everything?
> 
>  PVE/Storage/Plugin.pm   | 6 +++---
>  test/get_subdir_test.pm | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
>

applied, with trivial merge conflict for code-style fixes I did inbetween
resolved, thanks!

Also added a follow up that allows using dots, as long as it's not followed by
another dot, and enforces max-component and a overly-strict max-path length
here already.





More information about the pve-devel mailing list