[pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Mar 15 13:12:35 CET 2023


Am 15/03/2023 um 12:41 schrieb Dominik Csapak:
> if my example and all that could have been configured but
> would now be invalid are not valid ldap syntax anyway, i think
> we can get more strict and "break" someones config
> (as you said, shouldn't have worked anyway)
> or how do you see that @thomas?

yeah fine by me.

Breaking semantic is the one thing we want to avoid, technical breakages is
basically any change in some form and overly strict argument. And while not
all use cases (or implementations not following the spec one bases the decision
on) are known.

The argument is strong enough for me to go ahead with it, that is as long as
there's a pointer in the breaking changes section of release notes that is,
as then admins can find a reference to odd/changed behavior quickly and if
really an issue we can always fix it up then.

ps. trimming out unrelated quotes from mail replies is encouraged ;P





More information about the pve-devel mailing list