[pve-devel] [PATCH manager] ui: PBSEdit: cleanup iframe for paperkey

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Mar 13 10:50:54 CET 2023


Am 13/03/2023 um 09:30 schrieb Aaron Lauterer:
> On 3/11/23 17:49, Thomas Lamprecht wrote:
>> Am 10/03/2023 um 15:36 schrieb Aaron Lauterer:
>>> @@ -181,6 +187,7 @@ ${prettifiedKey}
>>>         printFrame.src = "data:text/html;base64," + btoa(html);
>>>       document.body.appendChild(printFrame);
>>> +    return printFrame;
>>
>> You could replace the whole patch with adding the following line here:
>>
>> me.on('destroy', () => document.body.removeChild(printFrame));
>>
>> can also apply directly with a Reported-by tag if you see nothing off with this,
>> whatever you prefer?
> 
> Sure go ahead. Your approach is a lot cleaner. :)
> 

Ack, pushed:
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b380cb5814ec551588dfcbd6c5ed190f01d54029





More information about the pve-devel mailing list