[pve-devel] applied: [PATCH common] certificate: actually print openssl errors

Thomas Lamprecht t.lamprecht at proxmox.com
Sat Mar 11 18:26:34 CET 2023


Am 07/03/2023 um 11:50 schrieb Fabian Grünbichler:
> print_errs (which is also called internally by die_now) will only 'warn' the
> collected error stack if the log level is set to tracing. otherwise, it will
> just return the error message(s) corresponding to the error stack as string.
> 
> while they are not always the most user-friendly ones, they do provide
> additional context that might help to find out what is actually causing a
> particular failure. both helpers here actually provide a meaninful user
> friendly context (via $msg) as final line.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 
> Notes:
>     noticed while testing Max' key check series
> 
>  src/PVE/Certificate.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, with merge conflict resolved as I dropped the unused warn helper
and made the error one a local sub instead of a $code ref in-between, thanks!





More information about the pve-devel mailing list