[pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons

Stefan Sterz s.sterz at proxmox.com
Fri Mar 10 14:08:37 CET 2023


the "proxmox-inline-button" class is redundant in the crisp theme as
it only sets the buttons text to black. we mainly use that class for
"help" buttons. this is useful in the dark theme, because we want help
buttons to stand out a bit so (possibly confused) users are drawn to
them more easily. removing the class here doesn't change anything for
"crisp", but makes the dark theme appear more consistent. also fixes
up an unnecessary space.

Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
---
 www/manager6/Workspace.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 78ab37b6..8cee3638 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -469,8 +469,8 @@ Ext.define('PVE.StdWorkspace', {
 				selview,
 				{
 				    xtype: 'button',
-				    cls: 'x-btn-default-toolbar-small proxmox-inline-button',
-				    iconCls: 'fa fa-fw fa-gear x-btn-icon-el-default-toolbar-small ',
+				    cls: 'x-btn-default-toolbar-small',
+				    iconCls: 'fa fa-fw fa-gear x-btn-icon-el-default-toolbar-small',
 				    handler: () => {
 					Ext.create('PVE.window.TreeSettingsEdit', {
 					    autoShow: true,
-- 
2.30.2






More information about the pve-devel mailing list