[pve-devel] [PATCH network/container/qemu-server 0/3] Drop unused `firewall` argument to {add, del}_bridge_fdb()

Christoph Heiss c.heiss at proxmox.com
Wed Mar 1 13:54:41 CET 2023

While working on this code, I noticed that ACAICS the `firewall`
argument is never used (nor even declared!) [0] in both of

Thus drop it everywhere and avoid needlessly passing around things which
are never used anyway.

Did some quick smoke-testing and everything kept working fine, but as
there are really no functional changes, this should not effect anything.

[0] https://git.proxmox.com/?p=pve-common.git;a=blob;f=src/PVE/Network.pm;h=355637b1;hb=HEAD#l299


Christoph Heiss (1):
      zones: Drop unused `firewall` argument to {add,del}_bridge_fdb()

 PVE/Network/SDN/Zones.pm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)


Christoph Heiss (1):
      net: Drop unused `firewall` argument to add_bridge_fdb()

 src/PVE/LXC.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Christoph Heiss (1):
      net: Drop unused `firewall` argument to {add,del}_bridge_fdb()

 PVE/QemuServer.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


More information about the pve-devel mailing list