[pve-devel] [PATCH eslint/manager/wt/pmg-gui/proxmox-backup v3] change eslint
Dominik Csapak
d.csapak at proxmox.com
Fri Jun 23 09:08:42 CEST 2023
from 'eslint' to 'pve-eslint' to avoid a conflict with debians 'eslint'
package which ships the same binary
to avoid breakage, pull out the eslint binary into a make variable and
use pve-eslint if it exists, and eslint otherwise
changes from v2:
* use $(shell command) instead of $(wildcard), thanks @thomas for the
suggestions, this makes it shorter + we don't have to use the full
path
* added Suggested-by trailers
changes from v1:
* use $(ESLINT)
* use $(wildcard) make builtin to check if pve-eslint exists, use eslint as fallback
* introduce defines.mk in pmg-gui for ESLINT variable
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defines.mk | 2 ++
www/manager6/Makefile | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
proxmox-widget-toolkit:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
src/Makefile | 6 +++---
src/defines.mk | 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
pmg-gui:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defines.mk | 1 +
js/Makefile | 6 ++++--
js/mobile/Makefile | 3 ++-
3 files changed, 7 insertions(+), 3 deletions(-)
create mode 100644 defines.mk
proxmox-backup:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defines.mk | 1 +
www/Makefile | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
--
2.30.2
More information about the pve-devel
mailing list