[pve-devel] [PATCH installer] tui: multiply the disk size back into bytes

Stefan Sterz s.sterz at proxmox.com
Thu Jun 22 08:56:26 CEST 2023

On 21.06.23 16:36, Thomas Lamprecht wrote:
> Am 21/06/2023 um 16:00 schrieb Stefan Sterz:
>> previously the installer correctly divided the value when using them
>> for the `FloatEditView`, but forgot to multiply the value again when
>> retrieving it after editing. this commit fixes that
>> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
>> ---
>> tested this only locally and didn't build the installer completelly.
>> i am not sure if the installer handles this value correctly once it
>> is forwarded to the perl installer. if the perl installer expects
>> bytes here, it should work just fine, though.
> no it doesn't it expects Gigabyte in floats, see:
> https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=9a2d64977f73cec225c407ff13765ef02e2ff9e9

alright, thanks for that, i am not too familiar with this code base ^^'.
should we then model these sizes as `f64` instead?

i'd go ahead and prepare a patch with that, but it's a bit more churn so
i want to make sure that's the way to go.

More information about the pve-devel mailing list