[pve-devel] [PATCH manager] pve7to8: add reminder comment for noout_wanted variable

Fiona Ebner f.ebner at proxmox.com
Wed Jun 21 18:19:48 CEST 2023


Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---

Applies to the master branch. It's enough the have the reminder here,
stable would even need a different patch because of changed context.

 PVE/CLI/pve7to8.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index 6b51e98e..d988c715 100644
--- a/PVE/CLI/pve7to8.pm
+++ b/PVE/CLI/pve7to8.pm
@@ -542,6 +542,7 @@ sub check_ceph {
 	    log_warn("unable to determine overall Ceph daemon versions!");
 	} elsif (keys %$overall_versions == 1) {
 	    log_pass("single running overall version detected for all Ceph daemon types.");
+	    # TODO: needs to be set to 1 in the stable branch each time! - find better solution?
 	    $noout_wanted = 0; # off post-upgrade, on pre-upgrade
 	} elsif (keys $ceph_versions_simple->{overall}->%* != 1) {
 	    log_warn("overall version mismatch detected, check 'ceph versions' output for details!");
-- 
2.39.2






More information about the pve-devel mailing list