[pve-devel] [PATCH installer] tui: Add a cancel button to Advanced bootdisk options

Christoph Heiss c.heiss at proxmox.com
Wed Jun 21 12:32:54 CEST 2023


LGTM.

On Wed, Jun 21, 2023 at 11:16:09AM +0200, Maximiliano Sandoval wrote:
> This matches the GUI installer which counts with a close (x) button.
>

Reviewed-by: Christoph Heiss <c.heiss at proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
>  proxmox-tui-installer/src/views/bootdisk.rs | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs
> index 3fdbe5b..eaf343d 100644
> --- a/proxmox-tui-installer/src/views/bootdisk.rs
> +++ b/proxmox-tui-installer/src/views/bootdisk.rs
> @@ -456,6 +456,7 @@ fn advanced_options_view(disks: &[Disk], options: Rc<RefCell<BootdiskOptions>>)
>          &(*options).borrow(),
>      ))
>      .title("Advanced bootdisk options")
> +    .dismiss_button("Cancel")
>      .button("Ok", {
>          let options_ref = options.clone();
>          move |siv| {
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>





More information about the pve-devel mailing list