[pve-devel] [PATCH installer] fix #4643: show a confirmation dialog when clicking abort
Maximiliano Sandoval
m.sandoval at proxmox.com
Tue Jun 20 11:02:40 CEST 2023
Note that unlike the rest of the file, we connect to the response signal
instead of using Gtk3::Dialog->run, the reason is that run blocks the
main loop used by GTK and this undesirable to the point where
Gtk3::Dialog->run was removed for GTK 4.
Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
proxinstall | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index fb365d4..015496b 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1353,7 +1353,17 @@ sub create_main_window {
my $abort = Gtk3::Button->new('_Abort');
$abort->set_can_focus(0);
$cmdbox->pack_start($abort, 0, 0, 10);
- $abort->signal_connect(clicked => sub { app_quit(-1); });
+ $abort->signal_connect(clicked => sub {
+ my $msg = 'Are you sure you want to abort the installation?';
+ my $dialog = Gtk3::MessageDialog->new($window, 'modal', 'question', 'yes-no', $msg);
+ $dialog->signal_connect(response => sub {
+ my ($dialog, $response) = @_;
+
+ $dialog->close();
+ app_quit(-1) if $response eq 'yes';
+ });
+ $dialog->present();
+ });
my $vbox2 = Gtk3::Box->new('vertical', 0);
$hbox->add($vbox2);
--
2.39.2
More information about the pve-devel
mailing list