[pve-devel] [PATCH v5 qemu-server 0/7] migration: don't scan all storages, fail on aliases

Aaron Lauterer a.lauterer at proxmox.com
Mon Jun 19 11:29:27 CEST 2023

This patch series changes the behavior during guest migrations:

Don't scan all storages for potential images belonging to the guest.
Only migrate images referenced in the config.
This made it necessary to handle pending changes explicitly which had
been covered by the storage scan.

We also added checks for any aliased volids and fail the migration if

The qemu-server part consists of quite a lot more commits since we had
to change a few things and for a better history, they are mostly their
own patches.

There is also a small patch for the documentation to add a hint that
aliased storages should be avoided.

changes since
- drop patch 4/12 rest regular config last
- refactor test_volid and ref handling -> is_attached
- reorder patches, first volid_changes reg. pending disks, then the
change in migration storage scanning
- rebase as 5/12 is already applied

- split it into many smaller commits
- changed / improved the handling of the 'ref's in
- fixed tests and added error handling in new mock functions
- rephrased the documentation hint

- style fixes
- qemu-server: mainly change the handling of pending changes
- container: use NEW_DISK_RE to check if the volume is a not yet created
pending volume

More in each patch.

qemu-server: Aaron Lauterer (7):
  qemuserver: foreach_volid: include pending volumes
  qemuserver: foreach_volid: always include pending disks
  migration: only migrate disks used by the guest
  qemuserver: migration: test_volid: change attr name and ref handling
  tests: add migration test for pending disk
  migration: fail when aliased volume is detected
  tests: add migration alias check

 PVE/QemuMigrate.pm                    |  82 +++++---------
 PVE/QemuServer.pm                     |  19 +++-
 test/MigrationTest/QemuMigrateMock.pm |  10 ++
 test/run_qemu_migrate_tests.pl        | 151 +++++++++++++++++++++++++-
 4 files changed, 198 insertions(+), 64 deletions(-)

container: Aaron Lauterer (2):
  migration: only migrate volumes used by the guest
  migration: fail when aliased volume is detected

 src/PVE/LXC/Migrate.pm | 51 +++++++++++++++++-------------------------
 1 file changed, 21 insertions(+), 30 deletions(-)

docs: Aaron Lauterer (1):
  storage: add hint to avoid storage aliasing

 pvesm.adoc | 6 ++++++
 1 file changed, 6 insertions(+)


More information about the pve-devel mailing list