[pve-devel] [PATCH v4 qemu-server, container, docs 0/12] migration: don't scan all storages, fail on aliases

Fiona Ebner f.ebner at proxmox.com
Fri Jun 16 16:12:53 CEST 2023

Am 16.06.23 um 11:56 schrieb Aaron Lauterer:
> Oh boy did this version explode in number of commits.

Made it very easy to already apply a patch and review the others and
catch the few remaining issues :)

As already discussed off-list, switching the attribute in foreach_volid
from referenced_in_config to is_attached and not have the unused disks
be part of is_attached might be best. Because whether the disk is
attached or not is what migration, being the only user of this
attribute, cares about.

Apart from the 'ref' handling, there's also

>                     my $msg = "can't migrate local cdrom drive";
>                     if (defined($snaprefs) && !$attr->{referenced_in_config}) {
>                         my $snapnames = join(', ', sort keys %$snaprefs);
>                         $msg .= " (referenced in snapshot - $snapnames)";
>                     }

but that can also just s/referenced_in_config/is_attached/

Consider patches 7/12 until 12/12:

Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>

More information about the pve-devel mailing list