[pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option

Fiona Ebner f.ebner at proxmox.com
Fri Jun 16 11:01:49 CEST 2023


Am 16.06.23 um 10:23 schrieb Thomas Lamprecht:
> Am 16/06/2023 um 09:35 schrieb Fiona Ebner:
>> The associated pve_verify_vmid() method already restricts the value
>> to this range, but this wouldn't be visible in the API viewer for
>> example [0].
>>
>> The verify method is also called by qemu-server's qmextract, so it's
>> not possible to just drop the method right now.
>>
>> [0]: https://forum.proxmox.com/threads/128845/post-564526
>>
>> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
>> ---
>>  src/PVE/JSONSchema.pm | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>>
> 
> applied, thanks!
> 
> let's see if we ever used values < 100 as some special thingy somwhere ;-P
> (if, those things should probably just switch to another format)

Even if, the problem is limited to cases where the format verification
wouldn't be done, but the min/max limits would apply. Can that even happen?





More information about the pve-devel mailing list