[pve-devel] applied: [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jun 15 18:11:22 CEST 2023

Am 15/06/2023 um 12:42 schrieb Stoiko Ivanov:
> The first two patches fix the setting of zfs_arc_min and zfs_arc_max via
> the kernel commandline - afaics they should not have been honored until
> now - verification was done in the debug-image by inspecting
> `grep '^c_' /proc/spl/kstat/zfs/arcstats`
> the first 2 patches can  be squashed - it explicitly split them out for
> ease of reviewing
> the last patch is more as an rfc, because it puzzled my why a debug-log
> message was not printed when running with debug.
> Stoiko Ivanov (3):
>   file-restore: add zfs. prefix to arc_min/max settings
>   file-restore: set zfs_arc_min to current minimum of 32M
>   file-restore: set loglevel considering PBS_QEMU_DEBUG
>  proxmox-file-restore/src/main.rs        | 7 ++++++-
>  proxmox-file-restore/src/qemu_helper.rs | 2 +-
>  2 files changed, 7 insertions(+), 2 deletions(-)

applied, thanks!

I made a follow-up to factor out the is-debug-mode logic in file-restore, not that
it gets out of sync when exactly it gets enabled (e.g., for some tools it's enough
if such a variable is set, even if empty, so if one would change one side but not
the other it could get confusing).

More information about the pve-devel mailing list