[pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property

[Thomas Lamprecht]

Am 14/06/2023 um 14:51 schrieb Fiona Ebner:
> Am 13.06.23 um 15:42 schrieb Alexander Zeidler:
>> Signed-off-by: Alexander Zeidler <a.zeidler at proxmox.com>
>> ---
>>  src/PVE/VZDump/Common.pm | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
>> index a6fe483..28ab0d3 100644
>> --- a/src/PVE/VZDump/Common.pm
>> +++ b/src/PVE/VZDump/Common.pm
>> @@ -282,6 +282,12 @@ my $confdesc = {
>>  	requires => 'storage',
>>  	optional => 1,
>>      },
>> +    "pbs-entries-max" => {
>> +	type        => 'integer',
>> +	description => "Override max number of entries to hold in memory (only applicable for PBS).",
>> +	optional    => 1,
>> +	minimum     => 1,
>> +	},
>>  };
> 
> Now I'm wondering if this would make sense as part of the 'performance'
> setting? Depending on how you interpret it, it could fit or not. Any
> other opinions?

+1, rather re-use existing infra for this and the performance settings are
a good enough fit, FWICT