[pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jun 14 13:38:59 CEST 2023

Am 14/06/2023 um 13:28 schrieb Aaron Lauterer:
> This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15.
> The bug should be fixed by now [0]. The reproducer doesn't cause any
> issues in my tests.
> [0] https://github.com/openzfs/zfs/issues/8541

hmm, torn on this one; 1 MB aligned images sound not to bad for various things,
and the extra size is rather negligible most of the time so we can mostly lose
here, otoh. it should be callers decision if storage works fine now..

> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> AFAICT this has an affect on EFI disks which after this revert will be
> 528k and not 1M. Similar as if we would store it as a .raw file.

that sounds like it _could_ break stuff..

@fiona: what was the state with local storage migration and those disk size
mismatches? Or anything else coming to your mind?

More information about the pve-devel mailing list