[pve-devel] [PATCH manager 1/2] ui: config panel: only set onlineHelp if it exists

Dominik Csapak d.csapak at proxmox.com
Wed Jun 14 11:50:46 CEST 2023


otherwise we might run into an exception further down

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/panel/ConfigPanel.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/www/manager6/panel/ConfigPanel.js b/www/manager6/panel/ConfigPanel.js
index d578f944..5192d2bc 100644
--- a/www/manager6/panel/ConfigPanel.js
+++ b/www/manager6/panel/ConfigPanel.js
@@ -130,7 +130,10 @@ Ext.define('PVE.panel.Config', {
 	if (me.savedItems[cardid]) {
 	    var curcard = me.getLayout().getActiveItem();
 	    var newcard = me.add(me.savedItems[cardid]);
-	    me.helpButton.setOnlineHelp(newcard.onlineHelp || me.onlineHelp);
+	    let onlineHelp = newcard.onlineHelp || me.onlineHelp;
+	    if (onlineHelp) {
+		me.helpButton.setOnlineHelp(onlineHelp);
+	    }
 	    if (curcard) {
 		me.setActiveItem(cardid);
 		me.remove(curcard, true);
-- 
2.30.2






More information about the pve-devel mailing list