[pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property

Fiona Ebner f.ebner at proxmox.com
Wed Jun 14 11:49:32 CEST 2023


Am 13.06.23 um 15:42 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler <a.zeidler at proxmox.com>
> ---
>  src/PVE/VZDump/Common.pm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index a6fe483..28ab0d3 100644
> --- a/src/PVE/VZDump/Common.pm
> +++ b/src/PVE/VZDump/Common.pm
> @@ -282,6 +282,12 @@ my $confdesc = {
>  	requires => 'storage',
>  	optional => 1,
>      },
> +    "pbs-entries-max" => {
> +	type        => 'integer',
> +	description => "Override max number of entries to hold in memory (only applicable for PBS).",

This is not really telling from a user perspective. Shouldn't we mention
how it relates to folders here? Also: only applicable for file-based PBS
backups.

> +	optional    => 1,
> +	minimum     => 1,

Style nit: we don't align the arrows for any other parameter here

> +	},
>  };
>  
>  sub get_confdesc {





More information about the pve-devel mailing list