[pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

Fiona Ebner f.ebner at proxmox.com
Tue Jun 13 09:05:58 CEST 2023

Am 12.06.23 um 16:54 schrieb Thomas Lamprecht:
> Am 12/06/2023 um 13:22 schrieb Fiona Ebner:
>> Instead of getting rid of the "print once per line" handling, can't we
>> rather adapt the invocation for backup to bubble up the other log lines too?
> would it make sense to differ between stderr/stdour and do log_warn and print,
> respectively?

Could also be done, but from a quick look in the code, QEMU also prints
its info_report() to stderr. Could lead to a bit of over-reporting as
warnings in our task logs, but might be fine for most cases; there's not
too many info_report instances.

>> Always prefixing the messages with "QEMU: " seems fine to me (even
>> things like the "bridge 'vmbr1' does not exist" message technically come
>> from the pve-bridge script, it's still part of the QEMU invocation ;)).
> not sure if we really need a prefix at all here..

Well, the migration code currently expects it and it helps to recognize
where the message comes from in complex logs like migration (and after
this bug is fixed, backup).

More information about the pve-devel mailing list