[pve-devel] [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text

Fiona Ebner f.ebner at proxmox.com
Fri Jun 9 16:16:25 CEST 2023

Could lead to a type error with classifyOrigin when there is a
repository that doesn't have an InRelease file and cannot be detected
as Debian/Proxmox origin from its URL. For me, it triggered with the
element.io repository after changing to bookworm (which currently
doesn't exist yet) and running apt update.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>

Not too difficult to run into with external repos during upgrade
preparation (when they are not yet bookworm-ready), so might also be
worth it for the stable branch?

 src/node/APTRepositories.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index cba9271..47c0a2c 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -697,7 +697,7 @@ Ext.define('Proxmox.node.APTRepositories', {
 			repo.Path = file.path;
 			repo.Index = n;
 			if (infos[file.path] && infos[file.path][n]) {
-			    repo.Origin = infos[file.path][n].origin || Proxmox.Utils.UnknownText;
+			    repo.Origin = infos[file.path][n].origin || Proxmox.Utils.unknownText;
 			    repo.warnings = infos[file.path][n].warnings || [];
 			    if (repo.Enabled) {

More information about the pve-devel mailing list