[pve-devel] partially-applied-series: [PATCH-SERIES v2 qemu-server/qemu] Some breaking QEMU changes

[Thomas Lamprecht]

Am 24/05/2023 um 15:56 schrieb Fiona Ebner:
> First one is dropping the custom get_link_status QMP command which I
> could not find any users for.
> 
> Second one is dropping left-over, custom, deprecated QMP commands for
> drive snapshotting.
> 
> Third one is dropping the dummy id CLI parameter, where the only
> remaining user I found is qmeventd, which is adapted to parse the VM
> ID from the cgroup proc file instead.
> 
> With the third change, new pve-qemu-kvm will break old qemu-server,
> requiring a versioned breaks.
> 
> 
> Changes in v2:
>     * also drop deprecated drive snapshot QMP commands
> 
> 
> qemu-server:
> 
> Fiona Ebner (3):
>   remove left-over mentions of to-be-dropped, outdated QMP commands
>   qmeventd: extract vmid from cgroup file instead of cmdline

applied, above two

>   cfg2cmd: drop custom id parameter
> 
>  PVE/QMPClient.pm                              |  4 +-
>  PVE/QemuServer.pm                             |  2 -
>  qmeventd/qmeventd.c                           | 50 +++++++++++--------
>  test/cfg2cmd/bootorder-empty.conf.cmd         |  1 -
>  test/cfg2cmd/bootorder-legacy.conf.cmd        |  1 -
>  test/cfg2cmd/bootorder.conf.cmd               |  1 -
>  ...putype-icelake-client-deprecation.conf.cmd |  1 -
>  .../custom-cpu-model-defaults.conf.cmd        |  1 -
>  .../custom-cpu-model-host-phys-bits.conf.cmd  |  1 -
>  test/cfg2cmd/custom-cpu-model.conf.cmd        |  1 -
>  test/cfg2cmd/efi-raw-old.conf.cmd             |  1 -
>  test/cfg2cmd/efi-raw-template.conf.cmd        |  1 -
>  test/cfg2cmd/efi-raw.conf.cmd                 |  1 -
>  test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd |  1 -
>  test/cfg2cmd/efi-secboot-and-tpm.conf.cmd     |  1 -
>  test/cfg2cmd/efidisk-on-rbd.conf.cmd          |  1 -
>  test/cfg2cmd/i440fx-win10-hostpci.conf.cmd    |  1 -
>  .../cfg2cmd/memory-hotplug-hugepages.conf.cmd |  1 -
>  test/cfg2cmd/memory-hotplug.conf.cmd          |  1 -
>  test/cfg2cmd/memory-hugepages-1g.conf.cmd     |  1 -
>  test/cfg2cmd/memory-hugepages-2m.conf.cmd     |  1 -
>  test/cfg2cmd/minimal-defaults.conf.cmd        |  1 -
>  test/cfg2cmd/netdev-7.0-multiqueues.conf.cmd  |  1 -
>  test/cfg2cmd/netdev-7.1-multiqueues.conf.cmd  |  1 -
>  test/cfg2cmd/netdev-7.1.conf.cmd              |  1 -
>  test/cfg2cmd/netdev.conf.cmd                  |  1 -
>  test/cfg2cmd/pinned-version-pxe-pve.conf.cmd  |  1 -
>  test/cfg2cmd/pinned-version-pxe.conf.cmd      |  1 -
>  test/cfg2cmd/pinned-version.conf.cmd          |  1 -
>  .../q35-linux-hostpci-multifunction.conf.cmd  |  1 -
>  ...q35-linux-hostpci-x-pci-overrides.conf.cmd |  1 -
>  test/cfg2cmd/q35-linux-hostpci.conf.cmd       |  1 -
>  test/cfg2cmd/q35-simple-6.0.conf.cmd          |  1 -
>  test/cfg2cmd/q35-simple-7.0.conf.cmd          |  1 -
>  test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd   |  1 -
>  test/cfg2cmd/q35-simple.conf.cmd              |  1 -
>  test/cfg2cmd/q35-usb2.conf.cmd                |  1 -
>  test/cfg2cmd/q35-usb3.conf.cmd                |  1 -
>  test/cfg2cmd/q35-win10-hostpci.conf.cmd       |  1 -
>  test/cfg2cmd/qemu-xhci-7.1.conf.cmd           |  1 -
>  test/cfg2cmd/qemu-xhci-q35-7.1.conf.cmd       |  1 -
>  test/cfg2cmd/seabios_serial.conf.cmd          |  1 -
>  ...imple-balloon-free-page-reporting.conf.cmd |  1 -
>  test/cfg2cmd/simple-btrfs.conf.cmd            |  1 -
>  test/cfg2cmd/simple-virtio-blk.conf.cmd       |  1 -
>  test/cfg2cmd/simple1-template.conf.cmd        |  1 -
>  test/cfg2cmd/simple1.conf.cmd                 |  1 -
>  test/cfg2cmd/spice-enhancments.conf.cmd       |  1 -
>  test/cfg2cmd/spice-linux-4.1.conf.cmd         |  1 -
>  test/cfg2cmd/spice-usb3.conf.cmd              |  1 -
>  test/cfg2cmd/spice-win.conf.cmd               |  1 -
>  test/snapshot-test.pm                         |  3 --
>  52 files changed, 31 insertions(+), 76 deletions(-)
> 
> 
> qemu:
> 
> Fiona Ebner (3):
>   drop patch for custom get_link_status QMP command
>   drop deprecated custom drive snapshot QMP commands


applied, above two

>   drop patch for custom dummy id CLI argument
> 

The id thing is just to small and we might not be the only users, for now let's keep it
if it makes problems this major release we can get it to the chopping block with actual
reasons then.