[pve-devel] [RFC ha-manager] manager: clear stale maintenance node in edge case

[Thomas Lamprecht]

Am 22/03/2023 um 17:21 schrieb Fiona Ebner:
> where the whole cluster was shut down at the same time and the
> service was never started on another node since the maintenance node
> was set.
> 
> If a user ends up in this edge case, it would be rather surprising
> that the service would ignore the rebalance on start setting and would
> be automatically migrated back to the "maintenance node" which
> actually is not in maintenance mode anymore after a migration away
> from it.
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> We could also think about doing the check more broadly in manage(), in
> preparation to add a feature where stopped services are also migrated
> during maintenance also. But that needs more consideration.
> 

No, I think this approach is fine as I like something targeted to next_state_started
(albeit it's getting a bit of a complex state in general, but until now it's still
IMO manageable)

But, the patch would need to be rebased it seems.