[pve-devel] applied: [PATCH-SERIES ha-manager] avoid rebalance-on-start for newly added already running service

[Thomas Lamprecht]

Am 14/04/2023 um 14:38 schrieb Fiona Ebner:
> As reported in the community forum[0], the current behavior when
> adding an already running service to HA is wrong. If rebalance
> selected a different node, the service would be stopped, offline
> migrated and started again. Since the rebalance-on-start is only
> intended to trigger on the stopped->start transition[1], this series
> makes sure the service is not migrated at all for rebalance-on-start
> if already running.
> 
> [0]: https://forum.proxmox.com/threads/125597/
> [1]: https://pve.proxmox.com/pve-docs/chapter-ha-manager.html#_crs_scheduling_points
> 
> Fiona Ebner (4):
>   sim: hardware: commands: fix documentation for add
>   sim: hardware: commands: make it possible to add already running
>     service
>   tools: add IGNORED return code
>   lrm: do not migrate if service already running upon rebalance on start
> 
>  src/PVE/HA/LRM.pm                             |  5 ++
>  src/PVE/HA/Manager.pm                         |  6 ++
>  src/PVE/HA/Sim/Hardware.pm                    | 16 +++--
>  src/PVE/HA/Tools.pm                           |  3 +-
>  src/test/test-crs-static-rebalance2/README    |  3 +
>  src/test/test-crs-static-rebalance2/cmdlist   |  9 +++
>  .../test-crs-static-rebalance2/datacenter.cfg |  7 +++
>  .../hardware_status                           |  5 ++
>  .../test-crs-static-rebalance2/log.expect     | 63 +++++++++++++++++++
>  .../test-crs-static-rebalance2/manager_status |  1 +
>  .../test-crs-static-rebalance2/service_config |  1 +
>  .../static_service_stats                      |  1 +
>  12 files changed, 115 insertions(+), 5 deletions(-)
>  create mode 100644 src/test/test-crs-static-rebalance2/README
>  create mode 100644 src/test/test-crs-static-rebalance2/cmdlist
>  create mode 100644 src/test/test-crs-static-rebalance2/datacenter.cfg
>  create mode 100644 src/test/test-crs-static-rebalance2/hardware_status
>  create mode 100644 src/test/test-crs-static-rebalance2/log.expect
>  create mode 100644 src/test/test-crs-static-rebalance2/manager_status
>  create mode 100644 src/test/test-crs-static-rebalance2/service_config
>  create mode 100644 src/test/test-crs-static-rebalance2/static_service_stats
> 


applied series, thanks!

But, I split the last commit into two, first one adding the (still broken) test,
then in the second the fix with the change to log.expect from broken -> fixed
encoded also in git. IME, this makes such changes a bit easier to understand and
evaluate when checking out the git log in the future.