[pve-devel] applied: [RFC manager] pveceph: add osd details command

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jun 6 18:24:08 CEST 2023

Am 19/12/2022 um 15:46 schrieb Aaron Lauterer:
> To provide similar output on the CLI as is possible in the GUI/API
> regaring OSD details.
> By default (output-format=text) a more concise output is shown. Using
> json or yaml as output format will print all the available data.
> The 'verbose' flag causes json-pretty output to be used.
> The functionality is split between the actual function and the output
> formatter as not all options/parameters are available in each.
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> Depends on the OSD Details patches which are not yet applied [0].
> RFC because in order to check against the output format and the verbose
> flag, the code ended up split between the actual cmdline method and
> the formatting function.
> The verbose flag is only available in the formatter and the verbose in
> the method itself.
> If there would be a nicer way to achieve a similar result, I would be
> happy to get hints.
> [0] https://lists.proxmox.com/pipermail/pve-devel/2022-December/055154.html
>  PVE/CLI/pveceph.pm | 66 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)

applied, with some (opinionated) code cleanups, thanks!

Looking at current CLI commands it seems a osd list is missing, as if I tried
this one first it asked for an OSD ID, and I thought well, how do I get one,
and yes `ceph osd tree` and co naturally, I know that, but a user that just
used pveceph might expect that there's some (osd) command that provides it
there too - so maybe we can add one.

More information about the pve-devel mailing list