[pve-devel] [PATCH/RFC widget-toolkit 2/5] apt repositories: just ignore unknown info rather than throwing an error

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jun 5 19:06:25 CEST 2023


Am 05/06/2023 um 17:43 schrieb Fiona Ebner:
> This will avoid breaking older UI when extending the backend.
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  src/node/APTRepositories.js | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
> index cb08bb6..ed58e5b 100644
> --- a/src/node/APTRepositories.js
> +++ b/src/node/APTRepositories.js
> @@ -660,8 +660,6 @@ Ext.define('Proxmox.node.APTRepositories', {
>  			if (!repoGrid.majorUpgradeAllowed) {
>  			    infos[path][idx].warnings.push(info);
>  			}
> -		    } else {
> -			throw 'unknown info';

otherwise we could use some Ext.Msg or at least log via console.warn (maybe it helps detecting
a missing thing someday), would both not break UI.

>  		    }
>  		}
>  






More information about the pve-devel mailing list