[pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] fix #4551: ui: use gettext on hardcoded byte units
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Jun 1 16:14:25 CEST 2023
Used wrong tag, this is for manager, not widget-toolkit...
Am 06/04/2023 um 13:38 schrieb Noel Ullreich:
> Since some languages translate byte units like 'GiB' or write them in their
> own script, this patch wraps units in the `gettext` function.
>
> While most occurrences of byte strings can be translated within the
> `format_size` function in `proxmox-widget-toolkit/src/Utils.js`, this patch
> catches those instances that are not translated.
>
> Signed-off-by: Noel Ullreich <n.ullreich at proxmox.com>
> ---
> www/manager6/ceph/OSD.js | 4 ++--
> www/manager6/form/DiskStorageSelector.js | 2 +-
> www/manager6/lxc/MPResize.js | 2 +-
> www/manager6/qemu/HDResize.js | 2 +-
> www/manager6/qemu/HardwareView.js | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
> index 2f12f94d..61fe5b06 100644
> --- a/www/manager6/ceph/OSD.js
> +++ b/www/manager6/ceph/OSD.js
> @@ -83,7 +83,7 @@ Ext.define('PVE.CephCreateOsd', {
> {
> xtype: 'numberfield',
> name: 'db_dev_size',
> - fieldLabel: gettext('DB size') + ' (GiB)',
> + fieldLabel: `${gettext('DB size')} (${gettext('GiB')})`,
> minValue: 1,
> maxValue: 128*1024,
> decimalPrecision: 2,
> @@ -137,7 +137,7 @@ Ext.define('PVE.CephCreateOsd', {
> {
> xtype: 'numberfield',
> name: 'wal_dev_size',
> - fieldLabel: gettext('WAL size') + ' (GiB)',
> + fieldLabel: `${gettext('WAL size')} (${gettext('GiB')})`,
> minValue: 0.5,
> maxValue: 128*1024,
> decimalPrecision: 2,
> diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js
> index abd46deb..d408b815 100644
> --- a/www/manager6/form/DiskStorageSelector.js
> +++ b/www/manager6/form/DiskStorageSelector.js
> @@ -148,7 +148,7 @@ Ext.define('PVE.form.DiskStorageSelector', {
> itemId: 'disksize',
> reference: 'disksize',
> name: 'disksize',
> - fieldLabel: gettext('Disk size') + ' (GiB)',
> + fieldLabel: `${gettext('Disk size')} (${gettext('GiB')})`,
> hidden: me.hideSize,
> disabled: me.hideSize,
> minValue: 0.001,
> diff --git a/www/manager6/lxc/MPResize.js b/www/manager6/lxc/MPResize.js
> index 881c037b..d560b788 100644
> --- a/www/manager6/lxc/MPResize.js
> +++ b/www/manager6/lxc/MPResize.js
> @@ -52,7 +52,7 @@ Ext.define('PVE.window.MPResize', {
> maxValue: 128*1024,
> decimalPrecision: 3,
> value: '0',
> - fieldLabel: gettext('Size Increment') + ' (GiB)',
> + fieldLabel: `${gettext('Size Increment')} (${gettext('GiB')})`,
> allowBlank: false,
> });
>
> diff --git a/www/manager6/qemu/HDResize.js b/www/manager6/qemu/HDResize.js
> index f9c7290d..29ff253b 100644
> --- a/www/manager6/qemu/HDResize.js
> +++ b/www/manager6/qemu/HDResize.js
> @@ -49,7 +49,7 @@ Ext.define('PVE.window.HDResize', {
> maxValue: 128*1024,
> decimalPrecision: 3,
> value: '0',
> - fieldLabel: gettext('Size Increment') + ' (GiB)',
> + fieldLabel: `${gettext('Size Increment')} (${gettext('GiB')})`,
> allowBlank: false,
> });
this seems to be cut-off here, missign the full context, thus I get:
Applying: fix #4551: ui: use gettext on hardcoded byte units
error: corrupt patch at line 70
More information about the pve-devel
mailing list