[pve-devel] [PATCH-SERIES v2 pve-manager/qemu-server] fix#4689 autofind node with proxyto_callback

Alexandre Derumier aderumier at odiso.com
Thu Jun 1 08:50:08 CEST 2023


Currently, to manage qemu && lxc vms, we always need to specify nodename in uri.

This is a problem with automation tools like terraform, where is node is registered
in the state of terraform.
(That mean, than if we move the vm on another node, terraform don't known it, and try to create the vm
again or can't delete the vm,...)

This can also be a potential problem with race, if we need to query /cluster/ressources to find the node, then another
query on the vm.

I have some discussion with fabian about it:

This patch series, find the nodename with proxyto_callback.

a new api endpoint /guests/  is defined:


This patch series currently implement callback for api2::qemu

todo (if this patch serie is ok for you):
api2::qemu::agent   (/guest/qemu/vmid/agent)
api2::lxc   (/guest/lxc/vmid)
api2::lxc::config   (/guest/lxc/vmid/config)
api2::lxc::status   (/guest/lxc/vmid/status)
api2::lxc::snapshot   (/guest/lxc/vmid/snapshot)
api2::firewall:vm (/guest/(qemu|lxc)/vmid/firewall )

changelog v2:

- fix pvesh param sending to proxyto_callback


Alexandre Derumier (2):
  api2: add /guests path
  pvesh: send params to check_proxyto like httpserver

 PVE/API2.pm        |  6 +++++
 PVE/API2/Guests.pm | 55 ++++++++++++++++++++++++++++++++++++++++++++++
 PVE/API2/Makefile  |  1 +
 PVE/CLI/pvesh.pm   | 13 ++++++-----
 4 files changed, 70 insertions(+), 5 deletions(-)
 create mode 100644 PVE/API2/Guests.pm


Alexandre Derumier (1):
  api2: qemu: add proxyto_callback to find node if not defined

 PVE/API2/Qemu.pm | 157 ++++++++++++++++++++++++++++++++---------------
 1 file changed, 109 insertions(+), 48 deletions(-)


More information about the pve-devel mailing list