[pve-devel] [PATCH v3 manager/container/guest-common/docs 1/5] api: backup: refactor backup permission check
Alexander Zeidler
a.zeidler at proxmox.com
Thu Jul 27 10:37:55 CEST 2023
Alter style to make the parameter check more concise
Signed-off-by: Alexander Zeidler <a.zeidler at proxmox.com>
---
Changes since v2:
* none
Changes since v1:
Apply Fiona's comments:
* shorten permission check
PVE/API2/Backup.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 45eb47e2..70753c2e 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -49,7 +49,7 @@ sub assert_param_permission_common {
raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key};
}
- if (defined($param->{bwlimit}) || defined($param->{ionice}) || defined($param->{performance})) {
+ if (grep { defined($param->{$_}) } qw(bwlimit ionice performance)) {
$rpcenv->check($user, "/", [ 'Sys.Modify' ]);
}
}
--
2.39.2
More information about the pve-devel
mailing list