[pve-devel] [PATCH manager 3/3] headerbar: center search box, make it adapt to the width of the browser

Lukas Wagner l.wagner at proxmox.com
Fri Jul 21 16:54:26 CEST 2023

On 7/21/23 15:54, Thomas Lamprecht wrote:
> unsure about this, need to think a bit and as a few other things
> are pending and some vacation too I'd say let's revisit in September
> (i.e., ping me then please) if I didn't get around to it.

Sure. Will do. I just experimented a bit and a few people quite liked it, so
I thought I'd give it a shot.

> On 21/07/2023 11:39, Lukas Wagner wrote:
>> Also adding a minWidth/maxWidth so that it doesn't become comically
>> large or small. The minimum size is roughly the same size as the
> you can use numbers here, IMO 168 px and 200 px is not roughly the
> same ^^
Well, I would still argue that for a user who just takes a glance and
is not actually counting pixels it's pretty similar ;)

>> search bar was before. The maxmium size is the same size as the
>> results grid, making them align nicely.
> Would be centering the search result grid then be good to? Also,
> making it bigger if viewport size allows it, e.g. due to having more
> stuff like the tags shown in there nowadays.
> Also, we predominantly use integer flex values, besides consistency
> one IMO has a better ration understanding there.

Okay, now I'm really glad that I resisted the temptation to use 1.61
(golden ratio), because that is actually where the 1.6 came from ;)
But noted, thanks.

- Lukas

More information about the pve-devel mailing list