[pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jul 21 16:04:32 CEST 2023

On 21/07/2023 11:39, Lukas Wagner wrote:
> This makes the header bar look a bit less cramped and ensures consistency
> if web interfaces are used side-by-side, e.g. on an ultrawide screen.> 
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
> Notes:
>     Disadvantage: We loose 8px of vertical space. However, I really think
>     this is negligible.

well we could also meed in the middle, if having 32, 34 or 36 px is
enough to make it "less cramped"? As I don't like ranking subjective
design tuning over actual UX, and even if just 8 px, it adds up
(especially when then uses this change to argue adding some white space
padding elsewhere).

Also, Proxmox Backup Server, Proxmox Mail Gateway have a relatively
different base UI structure too, and we normally try only hard to keep
things consistent in the same product, not that it hurts on its own to
do so also between products, but that shouldn't be the sole argument.

Still some polishing is good, and all in all this can be fine, but as
said I'd check for a trade-off.

More information about the pve-devel mailing list