[pve-devel] [PATCH manager 2/3] headerbar: show shortcut for search in emptyText

[Thomas Lamprecht]

On 21/07/2023 11:39, Lukas Wagner wrote:
> The shortcut is not really documented anywhere, so I think it make it a
> bit more obvious to the user.

style not: commit message should wrap text at 70 character columns.
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages

> 
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>  www/manager6/form/GlobalSearchField.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/GlobalSearchField.js b/www/manager6/form/GlobalSearchField.js
> index c009ac8b..8e5e13c0 100644
> --- a/www/manager6/form/GlobalSearchField.js
> +++ b/www/manager6/form/GlobalSearchField.js
> @@ -8,7 +8,7 @@ Ext.define('PVE.form.GlobalSearchField', {
>      extend: 'Ext.form.field.Text',
>      alias: 'widget.pveGlobalSearchField',
>  
> -    emptyText: gettext('Search'),
> +    emptyText: gettext('Search (Ctrl-Shift-F)'),

not true for MacOS though, maybe check navigator.platform for /mac/i and
depending on that use CTRL or ⌘ 

Semi-related, is the aria-keyshortcuts attribute actually set here?

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts