[pve-devel] [PATCH v3 proxmox-widget-toolkit 63/66] notification: add gui for notification groups

Lukas Wagner l.wagner at proxmox.com
Thu Jul 20 14:31:26 CEST 2023


On 7/19/23 15:32, Dominik Csapak wrote:
>> +    mixins: {
>> +    field: 'Ext.form.field.Field',
>> +    },
> 
> when implementing the field mixin you have to (quote from the extjs docs)
> 
> ---8<---
> You will also need to make sure that initField is called during the component's initialization.
> --->8---
> 
> so you normally need a (small) initComponent that calls that
> (otherwise you can have some strange effects when using the field)
> 

Thanks, added. For the record, `initField` requires `callParent` to be called before.

I noticed that we are missing a call to `initField` in the following components as well:

MultiDiskSelector (widget-toolkit)
VMCPUFlagSelector (pve-manager)
VMSelector (pve-manager)

Haven't looked into pmg/pbs stuff, maybe some components there might be missing it as well.

-- 
- Lukas





More information about the pve-devel mailing list