[pve-devel] [PATCH v3 pve-common 38/66] JSONSchema: increase maxLength of config-digest to 64

[Fiona Ebner]

Am 17.07.23 um 17:00 schrieb Lukas Wagner:
> The new notification backend is implemented in Rust where we use SHA256
> for config digests.
> 
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>  src/PVE/JSONSchema.pm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
> index 7589bba..49e0d7a 100644
> --- a/src/PVE/JSONSchema.pm
> +++ b/src/PVE/JSONSchema.pm
> @@ -93,10 +93,13 @@ register_standard_option('pve-bridge-id', {
>  });
>  
>  register_standard_option('pve-config-digest', {
> -    description => 'Prevent changes if current configuration file has different SHA1 digest. This can be used to prevent concurrent modifications.',
> +    description => 'Prevent changes if current configuration file has a different digest. '
> +	. 'This can be used to prevent concurrent modifications.',

Should we instead create a separate standard option
"pve-config-digest-sha256"? Then we can still clearly communicate which
digest it is to users of the API (mostly ourselves for this one, but
still). Might prevent some mix-up at some point in the future.

>      type => 'string',
>      optional => 1,
> -    maxLength => 40, # sha1 hex digest length is 40
> +    # sha1 hex digests are 40 characters long
> +    # sha256 hex digests are 64 characters long (sha256 is used in our Rust code)
> +    maxLength => 64,
>  });
>  
>  register_standard_option('skiplock', {